exec-server: trace RPC notifications#31690
Open
anp-oai wants to merge 1 commit into
Open
Conversation
This was referenced Jul 9, 2026
anp-oai
force-pushed
the
codex/exec-server-notification-spans
branch
from
8ac0e20 to
184bfb9
Compare
anp-oai
changed the base branch from
codex/exec-server-client-rpc-spans
to
codex/exec-server-rpc-span-fields
anp-oai
commented
Jul 9, 2026
anp-oai
force-pushed
the
codex/exec-server-notification-spans
branch
from
184bfb9 to
cb7f4cf
Compare
Collaborator
Author
|
@codex review in general but also look specifically at the effect of instrumenting the future in the select arm instead of as a variable above |
Contributor
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Jul 9, 2026
anp-oai
force-pushed
the
codex/exec-server-rpc-span-fields
branch
from
c671b06 to
1ecebbc
Compare
anp-oai
force-pushed
the
codex/exec-server-notification-spans
branch
from
cb7f4cf to
8de3c5a
Compare
jif-oai
approved these changes
Jul 9, 2026
| notification_span.record("otel.name", method); | ||
| let result = tokio::select! { | ||
| result = route(Arc::clone(&handler), notification) => result, | ||
| result = route(Arc::clone(&handler), notification).instrument(notification_span.clone()) => result, |
Collaborator
There was a problem hiding this comment.
NIT: can we instrument the whole notification dispatch here, rather than only the route future?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
initializedis the only registered inbound exec-server RPC endpoint that bypasses request tracing, leaving handshake handling absent from server traces.What
codex.exec_server.notificationserver span.Manual validation
just test -p codex-exec-server exec_server_accepts_initializejust test -p codex-exec-server(306 passed, 2 skipped)Stack